Allow customizing truncate! based on the algorithm
#28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
🚀 New features to boost your workflow:
|
Collaborator
Author
|
I talked to @lkdvos about this and we decide against this for now, we can bring it back if there is a compelling use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #27.
The idea here is that this allows customizing the truncation based on the algorithm if needed, in addition to the truncation strategy. The reasoning is that certain algorithm backends might output the spectrum in a different format/ordering, which would require a different implementation of the truncation.
I'm open to suggestions on other ways of implementing this. Right now it is based on passing the
TruncatedAlgorithmobject intotruncate!, which includes both the algorithm and the truncation strategy, and then by default it unwraps just the truncation strategy. An alternative could be to pass the truncation strategy and algorithm as separate arguments, though in general they might not be separate, for example in a sparse/low rank factorization like a randomized SVD or Krylov SVD.